blaginin commented on code in PR #899:
URL:
https://github.com/apache/arrow-rs-object-store/pull/899#discussion_r4457687959
##########
src/upload.rs:
##########
@@ -29,6 +29,36 @@ use tokio::task::JoinSet;
/// An upload part request
pub type UploadPart = BoxFuture<'static, Result<()>>;
+#[derive(Debug, Clone, Copy, Default)]
+pub(crate) enum MultipartUploadMode {
+ #[default]
+ Overwrite,
+ Create,
+}
+
+impl TryFrom<PutMode> for MultipartUploadMode {
+ type Error = Error;
+
+ fn try_from(mode: PutMode) -> Result<Self> {
+ match mode {
+ PutMode::Overwrite => Ok(Self::Overwrite),
+ PutMode::Create => Ok(Self::Create),
+ PutMode::Update(_) => Err(Error::NotSupported {
Review Comment:
brought here! in general, i'm trying to keep some bits for a follow up pr
(this one is quite big already). For example, Azure implementation will go on
top
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
