pitrou commented on a change in pull request #10270:
URL: https://github.com/apache/arrow/pull/10270#discussion_r643253931
##########
File path: cpp/src/arrow/dataset/file_csv_test.cc
##########
@@ -50,7 +50,10 @@ class CsvFormatHelper {
}
static std::shared_ptr<CsvFileFormat> MakeFormat() {
- return std::make_shared<CsvFileFormat>();
+ auto format = std::make_shared<CsvFileFormat>();
+ // Required for CountRows
+ format->parse_options.ignore_empty_lines = false;
Review comment:
Hmm, but then why is this change necessary? Is it just a byproduct of
how the tests are written?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
