bhaskargurram-ai commented on PR #11549: URL: https://github.com/apache/arrow-rs/pull/11549#issuecomment-6615158376
Thanks @alamb, pushed ff45c2a2 and b9fc42ea. try_new now takes a DataType directly, so the None path is gone. I also dropped the seconds special case and just compare the time units with ==. The writer stores seconds with no unit, so they now only match a column that has no unit either. Scale, fixed length and time unit are the only parameters that change the stored bytes, and timezone doesn’t. The tests now go through a small Written helper, which cut about 100 lines, and every_writer_type now also checks that values that were never written come back as not found. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
