Abhi2939 commented on issue #55372: URL: https://github.com/apache/arrow/issues/55372#issuecomment-6628854868
Hi @chrikrah, this looks like a clean fix. Are you still planning to open the PR? If you’d rather not, I’d be happy to take it. I’d add the check next to CheckQuantileOptions, call it from both the tdigest and hash_tdigest inits with the same message, and add tests in the three places you listed. I’ll leave q=NaN as it is now unless a maintainer wants it changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
