hcrosse commented on PR #1447: URL: https://github.com/apache/arrow-go/pull/1447#issuecomment-6639609390
@zeroshade Thanks for catching the dictionary path. The dictionary spaced path now checks the decoded count, and `TestReadRecordsRejectsShortDictionaryPageWithNulls` covers a shortened RLE run with one null and fails without the check. The other spaced readers already report short counts inside their decoders. I merged main and added `BenchmarkReadOptionalDictionaryColumn`, which shares its loop and setup with the benchmark from https://github.com/apache/arrow-go/pull/1444. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
