Rich-T-kid commented on code in PR #11071:
URL: https://github.com/apache/arrow-rs/pull/11071#discussion_r4473006226
##########
parquet-variant-compute/src/variant_array.rs:
##########
@@ -787,6 +787,7 @@ impl ShreddedVariantFieldArray {
/// or be a list, large_list, list_view or struct
///
pub fn try_new(inner: &dyn Array) -> Result<Self> {
+ let inner = canonicalize_shredded_types(inner)?;
Review Comment:
Both constructors still describe only the canonical `value` and
`typed_value` types. Please document that supported scalar arrays may be
dictionary-encoded, are decoded into canonical storage during construction, and
may allocate. The `canonicalize_shredded_types` comment should mention `value`
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
