adamreeve commented on code in PR #49855:
URL: https://github.com/apache/arrow/pull/49855#discussion_r4474508649
##########
cpp/src/parquet/properties.h:
##########
@@ -1235,6 +1236,14 @@ class PARQUET_EXPORT ArrowReaderProperties {
/// Return whether read coalescing is enabled.
bool pre_buffer() const { return pre_buffer_; }
+ /// Enable eviction of pre-buffered ranges as record batch generators
consume them.
+ ///
+ /// This is intended for one-pass consumers. It is safe with any row group
order, but
+ /// file order allows the cache to release memory progressively. Default is
false.
Review Comment:
I think this comment could be improved to make it easier to understand. How
about this:
```
This is intended for one-pass consumers, and reduces memory use by freeing
buffered ranges
that are no longer needed. It is safe to enable when reading row groups in
any order, but reading
them in file order allows the cache to release memory progressively. Default
is false.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
