amoeba commented on code in PR #4939:
URL: https://github.com/apache/arrow-adbc/pull/4939#discussion_r4474743689
##########
r/adbcdrivermanager/R/error.R:
##########
@@ -75,6 +75,15 @@ stop_for_error <- function(status, error) {
# Store the listified error information
cnd$error <- error
+ # R truncates printed error messages to getOption("warning.length")
+ # characters (1000 by default), which cuts off long driver manager
+ # messages such as the list of paths searched for a driver manifest.
+ # The limit applies to the whole printed message, including the
+ # "Error in <call> :" prefix, so always raise it to its maximum while
+ # the error is signalled; the option is restored when stop() unwinds.
Review Comment:
```suggestion
# Always temporarily raise warning.length to its maximum so driver
manager
# errors don't get truncated
```
This comment is unnecessarily verbose. How about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
