lidavidm commented on code in PR #4995:
URL: https://github.com/apache/arrow-adbc/pull/4995#discussion_r4475835628
##########
c/driver_manager/adbc_driver_manager_test.cc:
##########
@@ -1440,6 +1440,57 @@ TEST(DriverManagerNotFound,
RelativePathWithLibraryExtension) {
ADBC_LOAD_FLAG_DEFAULT);
}
+// A filename longer than the filesystem allows (usually 255 bytes) makes the
+// OS report an error (ENAMETOOLONG) instead of "not found". That must not
+// escape the driver manager as a C++ exception.
Review Comment:
Agreed, this is "talking about what the code used to do"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
