hcrosse commented on PR #1465: URL: https://github.com/apache/arrow-go/pull/1465#issuecomment-6641567041
@zeroshade Thanks for checking the edge cases. I removed the closure created for each slot. `findRun` now returns only the run index, and `runEnd` reads one run end, so the run search inlines into `isValidAt` and no longer allocates. Each slot still does a binary search. On a synthetic union with 4,096 slots and a run-end encoded child containing 256 runs, allocations per call dropped from 4,129 to 33. Behavior and tests are unchanged. I added a line to the user-facing section of the description: `is_null` on the `null` type now returns all true instead of all false. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
