ump45nose opened a new pull request, #55421: URL: https://github.com/apache/arrow/pull/55421
### Rationale for this change Fixes #55410. `utf8_is_printable` / `ascii_is_printable` use `allow_empty=true`, so an empty string returns true (same as Python `str.isprintable()`). Their `StringClassifyDoc(..., non_empty=true)` wording incorrectly said the string must be non-empty. ### What changes are included in this PR? Pass `non_empty=false` for both printable FunctionDocs so the generated description matches the kernels: - before: "emit true iff the string is non-empty and consists only of …printable…" - after: "emit true iff the string consists only of …printable…" (empty is vacuously true) ### Are these changes tested? Docs-only. Existing Python tests already assert `utf8_is_printable` matches `str.isprintable()` (including empty). I did not rebuild Arrow C++ in this environment; the change is limited to two `StringClassifyDoc` boolean arguments. ### Are there any user-facing changes? Docs / FunctionDoc text only (pyarrow docstring text derived from these FunctionDocs). ### AI assistance Assisted by an AI coding tool for locating the `StringClassifyDoc` call sites and drafting this PR text. I reviewed the kernel `allow_empty` flags against Python `str.isprintable()` and confirmed the two-line docs fix matches issue #55410. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
