Rich-T-kid commented on code in PR #12071:
URL: https://github.com/apache/arrow-rs/pull/12071#discussion_r4470413287
##########
arrow-ipc/src/reader.rs:
##########
@@ -915,6 +915,41 @@ fn update_dictionaries(
Ok(())
}
+/// Returns the first field with dictionary `id`, in
[`Schema::fields_with_dict_id`] order.
+///
Review Comment:
is there any reason why we don't just update `fields_with_dict_id` directly
instead of adding this as a separate method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
