raulcd commented on code in PR #55381:
URL: https://github.com/apache/arrow/pull/55381#discussion_r4479099095
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -747,6 +747,11 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Emscripten")
"${ARROW_EMSCRIPTEN_LINKER_FLAGS}
-sERROR_ON_WASM_CHANGES_AFTER_LINK=1
-sSTACK_SIZE=${ARROW_EMSCRIPTEN_TEST_STACK_SIZE} -sALLOW_MEMORY_GROWTH
-lnodefs.js -lnoderawfs.js --pre-js
${BUILD_SUPPORT_DIR}/emscripten-test-init.js"
)
endif()
+ # Abseil stack trace via emscripten_stack_snapshot() abort on
Emscripten<4.0.14
+ # if offset converter isn't enabled. Emscripten 4.0.14 removed the offset
converter
+ if(EMSCRIPTEN_VERSION VERSION_LESS "4.0.14")
Review Comment:
Thanks @tadeja. I think we should certainly bump that to latest (it has not
changed in 3 years). What about:
- we open a new issue tracking the bump on a separate issue/PR.
- we merge this as is, maybe add a comment on this line pointing to the new
issue to bump se we remove this if check afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
