Rich-T-kid commented on code in PR #12043:
URL: https://github.com/apache/arrow-rs/pull/12043#discussion_r4456329171


##########
arrow-row/src/lib.rs:
##########
@@ -2262,6 +2300,36 @@ pub fn encode_dictionary_values<K: 
ArrowDictionaryKeyType>(
     }
 }
 
+fn gather_dictionary_values<K: ArrowDictionaryKeyType>(

Review Comment:
   may be worth a follow to make this more performant. for now since the case 
were targeting is high cardinality dictionarys it should be fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to