Rich-T-kid commented on code in PR #12084:
URL: https://github.com/apache/arrow-rs/pull/12084#discussion_r4493557655
##########
arrow-ipc/src/compression.rs:
##########
@@ -431,6 +495,27 @@ mod tests {
);
}
+ #[test]
+ #[cfg(feature = "lz4")]
+ fn test_lz4_compression_reuses_context() {
Review Comment:
yea I just took a look at [their
docs](https://docs.rs/lz4_flex/latest/lz4_flex/frame/struct.FrameEncoder.html)
and I cant find anything we could use to assert this. any alternative does seem
quite hacky. I think relying on the benchmarks should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
