bkietz commented on a change in pull request #10397:
URL: https://github.com/apache/arrow/pull/10397#discussion_r643578392
##########
File path: cpp/src/arrow/compute/exec/expression.cc
##########
@@ -61,13 +61,22 @@ Expression call(std::string function,
std::vector<Expression> arguments,
call.function_name = std::move(function);
call.arguments = std::move(arguments);
call.options = std::move(options);
+
+ call.hash = std::hash<std::string>{}(call.function_name);
+ for (const auto& arg : call.arguments) {
+ call.hash ^= arg.hash();
+ }
return Expression(std::move(call));
}
const Datum* Expression::literal() const { return
util::get_if<Datum>(impl_.get()); }
+const Expression::Parameter* Expression::parameter() const {
Review comment:
a Parameter is a {field_ref, type, index} (with the last two properties
only available after `Bind`). During simplification against guarantees (which
are unbound), parameters must be compared by their field_refs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
