andygrove commented on PR #11482: URL: https://github.com/apache/arrow-rs/pull/11482#issuecomment-6724011368
Pushed d7704adc7 (merge with main) and ecd86af85 (review changes). - 2: CI now runs the `arrow-cast`, `arrow-csv` and `arrow-json` tests with `arrow-array/jiff`, and the wasm32-unknown-unknown build includes `jiff`. - 3: With both features on, new tests compare the engines' names, UTC and local offsets, and gaps. Offsets and gaps are checked weekly over 1900 to 2099 and on each side of every transition. The allowlist holds the same 13 zones reported above, and failures print both tzdb releases. - 4: `Debug` for `Tz` and `TzOffset` matches chrono-tz again, with a test. - 5: I kept 16 bytes rather than adding an index lookup on every offset, and added a compile-time assertion for 64-bit targets. wasm32 pointers are smaller, so the sizes differ there. - 6: The table is now built from `jiff_tzdb` directly, with `UTC` special-cased as in jiff's bundled database. `tzdb-bundle-always` is gone, and the keys are `&'static str`. - Nits: added the bench comment and the doc comment for local datetimes outside jiff's range. Merging main also meant implementing `GapInfo` for jiff. Its tests now run on both engines, and the comparison test checks it against chrono-tz. The post-2038 cost is still open, as a follow-up before jiff becomes the default. I haven't rerun the benchmarks on an idle machine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
