rok commented on PR #55264: URL: https://github.com/apache/arrow/pull/55264#issuecomment-6747054087
> * How should the type checkers be run? Through pre-commit, through the `python_test_type_annotations.sh` script? Manually calling `mypy` or one of the others (in your typical local dev env)? Yes. TODO(rok) > * Do we already want to run the type checkers on the pyarrow tests? (or a subset of the test files) The PR seems to not yet do this, but on the other hand has a bunch of (partly incorrect?) changes to the test files (I started adding comments on those changes, but then stopped doing that). I would make a choice one way or the other. > (if we are currently not actually running the type checkers against the tests code, I would leave out all changes to those files for a subsequent PR; the changes are not lost, they can be cherry-picked in a follow-up PR) We currently do not, but once we have enough coverage we should > I tried with opening a new vscode window, select my dev env as python interpreter, and start a python file with some pyarrow code. It could infer types when hovering or doing tab completion (and this does work when selecting a python env that has pyarrow-stubs installed) For me with pycharm there was an issue with folder structure, `python/pyarrow-stubs/pyarrow/..` -> `python/pyarrow-stubs/..` fixes it. Will make a change for this. TODO(rok) > * Should we add stubtest to CI? (that seems important to ensure the code and stubs don't drift on subsequent changes) Yes. TODO(rok) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
