hcrosse commented on code in PR #1490:
URL: https://github.com/apache/arrow-go/pull/1490#discussion_r4516264769
##########
arrow/scalar/append.go:
##########
@@ -155,6 +155,8 @@ func appendToBldr(bldr array.Builder, scalars []Scalar)
error {
appendBinary(bldr, scalars)
case *array.BinaryBuilder:
appendBinary(bldr, scalars)
+ case *array.BinaryViewBuilder:
+ appendBinary(bldr, scalars)
Review Comment:
`appendBinary` now reserves data space for view builders only for values
longer than the 12 byte inline limit, so inline values no longer leave an empty
data buffer. `TestAppendViewScalars` now checks that appending only inline
values yields an array with no data buffers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
