Rich-T-kid commented on code in PR #12140:
URL: https://github.com/apache/arrow-rs/pull/12140#discussion_r4517449299
##########
parquet/benches/arrow_writer.rs:
##########
@@ -765,6 +765,17 @@ fn create_string_bench_batch_non_null(
)?)
}
+fn create_empty_string_bench_batch(size: usize) -> Result<RecordBatch> {
+ let schema = Schema::new(vec![Field::new("_1", DataType::Utf8, false)]);
+ // Like `concat`, `take` and `interleave`, `from_iter_values` gives an
+ // all-empty array a values buffer without an allocation.
Review Comment:
```suggestion
// gives an all-empty array a values buffer
// without an allocation.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
