adamreeve commented on code in PR #55423:
URL: https://github.com/apache/arrow/pull/55423#discussion_r4518512404
##########
cpp/src/arrow/dataset/partition.h:
##########
@@ -209,8 +219,17 @@ class ARROW_DS_EXPORT KeyValuePartitioning : public
Partitioning {
/// Convert a Key to a full expression.
Result<compute::Expression> ConvertKey(const Key& key) const;
+ /// Format partition values as path segments, encoding them according to
+ /// options_.segment_encoding.
+ ///
+ /// \param[in] values the partition values for each schema field
+ /// \param[in] escape_filename_separator whether values must not contain the
+ /// filename partitioning separator ("_"). It is escaped when using
Review Comment:
Yeah this does sound a bit awkward, I've reworded it in
f1d84048110f075bc8159775f43ffc3c85c69248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
