adamreeve commented on code in PR #55345:
URL: https://github.com/apache/arrow/pull/55345#discussion_r4518601822
##########
cpp/src/arrow/dataset/partition.cc:
##########
@@ -755,7 +755,18 @@ Result<PartitionPathFormat> HivePartitioning::FormatValues(
// field_index <-> path nesting relation
segments[i] = name + "=" + hive_options_.null_fallback;
} else {
- segments[i] = name + "=" + arrow::util::UriEscape(values[i]->ToString());
+ std::string value = values[i]->ToString();
+ switch (hive_options_.segment_encoding) {
+ case SegmentEncoding::None:
+ break;
Review Comment:
Hi @Niltra, thanks for working on this. I have a PR open for the opposite
scenario in directory and filename partitioning, which currently do no segment
encoding when writing: #55423
As part of my PR, I've also made some changes to the no-encoding path so
that it raises errors on invalid path segments.
I think we should wait until my PR is merged, and then re-use the validation
here for Hive partitioning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
