peterolkhov opened a new pull request, #1499:
URL: https://github.com/apache/arrow-go/pull/1499
### Rationale for this change
CSV list parsing trims all leading and trailing braces, including braces
that belong to child values. A list containing `"{hello}"` reads back as
`"hello"`, `"{}"` becomes an empty list, and nested singleton lists can fail to
parse.
### What changes are included in this PR?
Remove exactly one validated outer brace pair in both list parsers. Add
writer-to-reader equality tests for all five list variants, brace-bearing
strings, CSV quoting, nested lists, empty lists and null lists.
### Are these changes tested?
The new regression fails before the fix and passes after it. All CSV
tests/examples pass normally and with `-race -short -tags assert,test` and
`assert,test,noasm`. CSV-scoped golangci-lint 2.13.2 reports zero issues;
configured gofmt/goimports checks pass.
The full Arrow/Parquet suites and pre-commit checks have not been run
locally. CI still needs to cover those checks.
### Are there any user-facing changes?
CSV written by this package preserves braces in list strings and wrappers
around nested singleton lists when read back. Inputs that depended on silently
removing extra braces around scalar numeric values may now fail parsing.
AI assistance: prepared with OpenAI Codex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
