jonkeane commented on code in PR #55461:
URL: https://github.com/apache/arrow/pull/55461#discussion_r4525553193


##########
r/tools/nixlibs.R:
##########
@@ -871,6 +874,39 @@ set_thirdparty_urls <- function(env_var_list) {
   env_var_list
 }
 
+with_vendored_dependencies <- function(env_var_list) {
+  # libarrow requires some thirdparty dependencies, even for a minimal build.
+  # The libarrow build uses them from the system if they are available and
+  # otherwise builds them from source, downloading from ARROW_*_URL. To make 
sure
+  # that works without network access, `make sync-cpp` saves their source
+  # tarballs into vendored_dependency_dir and we point ARROW_*_URL at them 
here.
+  # This does not change whether the system versions are used.

Review Comment:
   ```suggestion
   # libarrow requires some thirdparty dependencies, even for a minimal build.
   # The libarrow build uses them from the system if they are available and
   # otherwise builds them from source, downloading from ARROW_*_URL. To make 
sure
   # that works without network access, `make sync-cpp` saves their source
   # tarballs into vendored_dependency_dir and we point ARROW_*_URL at them 
here.
   # This does not change whether the system versions are used.
   with_vendored_dependencies <- function(env_var_list) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to