Copilot commented on code in PR #55484:
URL: https://github.com/apache/arrow/pull/55484#discussion_r4536434614
##########
dev/release/post-10-bump-versions.sh:
##########
@@ -42,6 +42,11 @@ version=$1
next_version=$2
next_version_snapshot="${next_version}-SNAPSHOT"
current_version_before_bump="$(current_version)"
+# The default branch requires the "Merge check" status check. So we
+# can't push to the default branch directly. We need to use a pull
+# request.
+branch_name="bump-versions-${next_version}"
Review Comment:
Successive maintenance releases can share `next_version`, so this reuses the
same branch name. If the previous local branch still exists, `git checkout -b`
at line 83 aborts before any changelog or version updates. Include the released
version in the branch name as well, and update the example in
`docs/source/developers/release.rst:627`.
##########
.github/workflows/dev_pr_merged.yml:
##########
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Dev PR merged
+
+on:
+ push:
+ branches:
+ - main
Review Comment:
With `PR_TITLE_AND_DESC`, a squash commit can retain `[skip ci]`, `[ci
skip]`, or a `skip-checks` trailer from the PR body. GitHub then skips this
`push` workflow, so issue closure, milestone assignment, and label cleanup
never run. Use `pull_request_target: closed` for merged PRs targeting `main`,
check out trusted `apache/arrow` `main`, and call the existing `resolve` export
with the event PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
