siddubakka commented on issue #10931: URL: https://github.com/apache/arrow-rs/issues/10931#issuecomment-6801609724
@adriangb the issue lists two possible resolutions and says the intent is unclear I would like to fix the writer rather than the docs: in write_batch_internal the compact levels branch should use the smaller of write_batch_size and data_page_row_count_limit, so the knob named in the documentation is the one that bounds the batch. A regression test from the repro would cover it, checking that page boundaries move with write_batch_size when the def levels are Uniform Is that the direction the project wants, or should the docs describe the current behavior instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
