zeroshade commented on PR #1505:
URL: https://github.com/apache/arrow-go/pull/1505#issuecomment-6802084070
@amoeba thanks, I took your patch as is in ce4d4023: the list writer now
formats items through `encodeListItems`, and `listItemNeedsQuotes` also quotes
empty items and braces.
On `["a}"]`: this branch was cut before #1499 merged, and the reader then
trimmed every leading and trailing brace, which is what dropped the `}`. I
rebased onto main, which has #1499's reader fix. There, the previous writer
output `{a}}` already reads back as `["a}"]`. Quoting braces is still worth
having, though: with your change the output reads back correctly even with the
pre-#1499 reader, which I checked by swapping it in.
`TestCSVWriteListItemsNeedingQuotes` now includes `["a}"]` and `["{b", "c"]`.
I also updated #1508, which builds on this, to use the same helper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
