Copilot commented on code in PR #55319:
URL: https://github.com/apache/arrow/pull/55319#discussion_r4544300057
##########
r/configure.win:
##########
@@ -89,7 +89,8 @@ function configure_binaries() {
PKG_LIBS="-L${RWINLIB}/lib"'$(subst gcc,,$(COMPILED_BY))$(R_ARCH) '
PKG_LIBS="$PKG_LIBS -L${RWINLIB}/lib"'$(R_ARCH)$(CRT) '
PKG_LIBS="$PKG_LIBS -larrow_dataset -larrow_acero -lparquet -larrow_compute
-larrow_s3 \
- -larrow_gcs -larrow -larrow_bundled_dependencies \
+ -larrow_gcs -larrow_gcs_bundled_dependencies -larrow \
Review Comment:
Adding this archive unconditionally breaks Windows R builds using pre-split
binaries: those distributions contain the SDK in
`libarrow_bundled_dependencies.a` and have no
`libarrow_gcs_bundled_dependencies.a`, so the linker fails with `cannot find
-larrow_gcs_bundled_dependencies`. `tools/nixlibs.R` still accepts
pre-downloaded binaries (`ARROW_DOWNLOADED_BINARIES`/`RWINLIB_LOCAL`) and
selects the latest available nightly independently of this checkout. Please add
this flag only when the selected binary distribution contains the new archive,
as the Unix configure path already does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
