AlenkaF commented on code in PR #51161:
URL: https://github.com/apache/arrow/pull/51161#discussion_r4552455598
##########
python/pyarrow/tests/test_misc.py:
##########
@@ -290,3 +290,32 @@ def test_extension_type_constructor_errors(klass):
msg = f"Do not call {klass.__name__}'s constructor directly, use .*
instead."
with pytest.raises(TypeError, match=msg):
klass()
+
+
[email protected]
[email protected](("module", "call", "message"), [
+ pytest.param(
+ "acero", "ScanNodeOptions(None)", "Argument 'dataset'",
+ marks=[pytest.mark.acero, pytest.mark.dataset], id="scan"),
+ pytest.param(
+ "acero", "ProjectNodeOptions([None])", "Expression must not be None",
+ marks=pytest.mark.acero, id="project"),
+ pytest.param(
+ "parquet", "ParquetSchema(None)", "Argument 'container'",
+ marks=pytest.mark.parquet, id="parquet-schema"),
+ pytest.param(
+ "parquet", "ColumnSchema(None, 0)", "Argument 'schema'",
+ marks=pytest.mark.parquet, id="column-schema"),
+ pytest.param(
+ "fs", 'SubTreeFileSystem("", None)', "Argument 'base_fs'",
+ id="subtree"),
+])
Review Comment:
Yes, the marks comment is correct. I would also like to pass on subprocesses
if possible. Could we simply check `with pytest.raises ...` as elsewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]