hcrosse opened a new pull request, #1540: URL: https://github.com/apache/arrow-go/pull/1540
### Rationale for this change Wrapping dictionary storage panics or silently loses its dictionary. ### What changes are included in this PR? I retain the storage dictionary with `SetDictionary`, as `ExtensionArrayBase.setData` already does. ### Are these changes tested? `TestNewExtensionArrayWithStorageKeepsDictionary` fails on main and passes with this change. It checks independent lifetimes by validating the extension, releasing it, then validating the original storage. A checked allocator confirms that all memory is released. With Go 1.26.10, vet, `go test -race -tags assert,test ./arrow/...` with pinned `arrow-testing` and `parquet-testing` data, `golangci-lint` 2.13.2 and the Release Audit Tool passed. ### Are there any user-facing changes? Yes. `NewExtensionArrayWithStorage` preserves the storage dictionary. There is no API change. Closes https://github.com/apache/arrow-go/issues/1535. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
