Rich-T-kid commented on code in PR #12122:
URL: https://github.com/apache/arrow-rs/pull/12122#discussion_r4553924491
##########
parquet/src/column/writer/encoder.rs:
##########
@@ -84,7 +84,16 @@ pub trait ColumnValueEncoder {
fn write(&mut self, values: &Self::Values, offset: usize, len: usize) ->
Result<()>;
/// Write the values at the indexes in `indices` to this
[`ColumnValueEncoder`]
- fn write_gather(&mut self, values: &Self::Values, indices: &[usize]) ->
Result<()>;
+ ///
+ /// `num_values_in_batch` is the total number of selected non-null values
in the
+ /// enclosing batch, including any other mini-batches. Arrow callers
provide an
+ /// exact selection with no unused trailing indices.
Review Comment:
what does `other mini-batches` mean here? also what happends if there are
unused trailing indices
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
