bkietz commented on a change in pull request #10397:
URL: https://github.com/apache/arrow/pull/10397#discussion_r644299278
##########
File path: cpp/src/arrow/compute/exec/exec_plan.cc
##########
@@ -105,18 +107,11 @@ struct ExecPlanImpl : public ExecPlan {
return Status::OK();
}
- auto it_success = visiting.insert(node);
- if (!it_success.second) {
- // Insertion failed => node is already being visited
- return Status::Invalid("Cycle detected in execution plan");
- }
Review comment:
Since nodes are now constructed with their inputs it's impossible to
produce a cycle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
