Awesome06 commented on code in PR #55425:
URL: https://github.com/apache/arrow/pull/55425#discussion_r4560135554


##########
cpp/src/arrow/compute/kernels/scalar_compare_test.cc:
##########
@@ -1255,20 +1262,36 @@ TEST(TestBinaryViewCompareKernel, ArrayScalar) {
       };
 
   for (const auto& [arr_type, scalar_type] : cases) {
-    auto arr = ArrayFromJSON(arr_type, R"(["", "abc", "abcdefghijklmnop", 
null])");
+    auto arr = ArrayFromJSON(
+        arr_type, R"(["", "abc", "abcdefghijklmnop", 
"equal_long_string_12345", null])");

Review Comment:
   Added both in the latest update:
   1. **Inlined prefix collisions:** Added `"abcdefgh"` vs `"abcdefgX"` (length 
8, matching 4-byte prefix `"abcd"`, differing inlined tail) across `ArrayArray` 
and `ArrayScalar` to exercise the second 64-bit register compare.
   2. **Multiple variadic buffers:** Added 
`TestBinaryViewCompareKernel.MultiplePayloadBuffers` testing views referencing 
distinct payload buffers (`buffer_index == 0, 1, 2`) compared against views, 
scalars, and standard offset-based string arrays.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to