agriyakhetarpal commented on PR #55588: URL: https://github.com/apache/arrow/pull/55588#issuecomment-6855003035
For two, yet another follow-up work/PRs after this: 1. I was exploring PyArrow in WASM a bit more, having not used it as much, and found that we can actually easily enable the `bz2` (`ARROW_WITH_BZ2`) feature and enable some more testing here – and we can adopt the same for our PyArrow recipe in https://github.com/pyodide/pyodide-recipes. It will add less than 100 KiB to our wheel, which is 11.3 MiB, so the change is small. 2. Another issue I found is that the `pyodide-unix-timezones` package we ship as a PyArrow dependency to provide zoneinfo data doesn't work at all, because it's a stub and the wheel is empty. What a surprise :D No one raised this either, as far as I can tell. When I tried this with `assume_timezone(arr, "Europe/Paris")` in our REPL online, it failed with `discover_tz_dir failed to find zoneinfo`. Initially, in pyodide/pyodide#4889, the fat timezones were being added, and later in the PR, the package was moved to PyPI but the data was not added there, there's only an `__init__.py` file 😄 After that, post pyodide/pyodide#4892, we have supported data files, so we can probably add the fat timezones in our `pyodide-unix-timezones` recipe. That package only exists because of these two issues: apache/arrow#42157 and apache/arrow#49353. If those get implemented, or if we could use `std::chrono` on Emscripten too (beyond Windows as noted in https://github.com/apache/arrow/pull/49353#issuecomment-3998148568), then PyArrow on Pyodide can simply rely on slim files and use `tzdata`, which is already a dependency because of `pandas`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
