mbutrovich commented on code in PR #12232:
URL: https://github.com/apache/arrow-rs/pull/12232#discussion_r4564707925
##########
arrow-buffer/src/bigint/mod.rs:
##########
@@ -910,7 +910,7 @@ const fn split_array<const N: usize, const M: usize>(vals:
[u8; N]) -> ([u8; M],
///
/// This mirrors the x86 mulx instruction but for 128-bit types
#[inline]
-const fn mulx(a: u128, b: u128) -> (u128, u128) {
+pub(crate) const fn mulx(a: u128, b: u128) -> (u128, u128) {
Review Comment:
The divisors reuse the 128x128-bit multiply from `mulx` for the high
multiplies, and `div::div_rem` (Algorithm D) to compute the `i256` multiplier.
Neither becomes public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
