paleolimbot commented on issue #4771: URL: https://github.com/apache/arrow-adbc/issues/4771#issuecomment-6856364008
This seems reasonable to me (and would work for the initial case we'd considered, which is wrapping libpq's quoting functions I believe)...the only downside is that it's heavy (AdbcStatement + ArrowSchema + ArrowArray for the bind, ArrowArrayStream + ArrowSchema + ArrowArray for the result), but possibly nobody will notice. The other intial proposal was to run everything through `GetOption()` with a specially structured key value, which is kind of a hack and requires computing a result potentially twice, but is much lighter weight. In Sedona's ABIs I run anything serializable through something like `int GetProperty(self, const char* name, const char* json_args, struct ArrowSchema* out, struct ArrowArray* out_data)`, which is somewhere in the middle. Probably the ExecuteQuery thing is good enough! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
