Phoenix500526 opened a new pull request, #12240:
URL: https://github.com/apache/arrow-rs/pull/12240

   # Which issue does this PR close?
   
   - Closes #10082
   
   # Rationale for this change
   
   Flight SQL servers can indicate whether a prepared statement should use the 
query or update execution path. Expose this information to Rust callers so they 
can choose the corresponding execution method without inferring it from the 
result schema.
   
   # What changes are included in this PR?
   
   - Sync the upstream optional `is_update` protobuf field and regenerate the 
Rust bindings.
   - Preserve the field in `PreparedStatement` and expose `is_update() -> 
Option<bool>`, with a documentation example showing caller-controlled execution.
   - Set `Some(false)` in the server example and retain `None` in the existing 
CLI test server.
   
   # Are these changes tested?
   
   A client integration test verifies that `Some(true)`, `Some(false)`, and an 
absent field survive protobuf encoding, gRPC transport, and `prepare()`. The 
server example's `test_select` also checks the hint through UDS, HTTP, and 
HTTPS. The API documentation example is compile-tested.
   
   The Flight unit, integration, CLI, and documentation tests pass, as do the 
server example tests with the documented `flight-sql,tls-ring` features. 
Workspace Clippy, formatting, and spelling checks pass. The full workspace test 
run stops in `arrow-pyarrow` because the local environment cannot load 
`libpython3.12.dylib`. Running the server example with all features also 
encounters a Rustls provider-selection conflict; the documented single-provider 
configuration passes.
   
   # Are there any significant user-facing changes?
   
   **Breaking Rust source API change:** the public 
`ActionCreatePreparedStatementResult` struct gains `pub is_update: 
Option<bool>`. Downstream struct literals that enumerate its fields must 
initialize the new field, for example with `is_update: None`. This change needs 
the `api-change` label and a major-release merge window under the repository's 
compatibility policy.
   
   The protobuf change is wire-compatible: absent fields remain `None`, and 
older clients can ignore the added field. The other new public API, 
`PreparedStatement::is_update(&self) -> Option<bool>`, is additive. Execution 
remains explicitly selected by the caller through the existing `execute()` and 
`execute_update()` methods.
   
   # AI usage disclosure
   
   Codex assisted with the protocol and client changes, examples, tests, 
documentation, review, and PR preparation. Rust protobuf bindings were 
regenerated with the repository's generator.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to