Jimexist commented on a change in pull request #463:
URL: https://github.com/apache/arrow-datafusion/pull/463#discussion_r644407379
##########
File path: datafusion/src/sql/planner.rs
##########
@@ -1091,10 +1109,13 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
// then, window function
if let Some(window) = &function.over {
- if window.partition_by.is_empty()
- && window.order_by.is_empty()
- && window.window_frame.is_none()
- {
+ if window.partition_by.is_empty() &&
window.window_frame.is_none() {
Review comment:
they need to be empty otherwise it goes to the unsupported error clause
which is needed to guard unintended usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
