ump45nose commented on PR #55338:
URL: https://github.com/apache/arrow/pull/55338#issuecomment-6867674101

   Pushed a follow-up to the two R failures from the last run:
   
   - `test-compute-arith.R:93` (`a %% 2` with an integer array): the modulo 
kernel promotes an integer numerator with a double divisor to double, so the 
result no longer had the numerator's integer type. Floating-point divisors now 
keep the previous `%/%` rewrite; the kernel branch is used for exact types 
only, and now also covers decimals.
   - `test-dplyr-funcs-math.R:472` was my test comparing against `bit64`'s 
`%%`, which rounds the dividend. It now pins the exact remainder (2^60 + 5 mod 
7 = 6) and asserts the result type is int64, plus a negative-dividend case for 
R's floor semantics.
   
   I could not run the R suite locally: this machine has no R toolchain and 
installing one is out of scope for my setup, so the change is verified only by 
review and by CI once it runs. Could a committer trigger the R jobs?
   
   (AI-assisted change and comment.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to