dayan02dev commented on code in PR #12246:
URL: https://github.com/apache/arrow-rs/pull/12246#discussion_r4571301133
##########
parquet-variant-compute/src/cast_to_variant.rs:
##########
@@ -45,16 +45,16 @@ pub fn cast_to_variant_with_options(
input: &dyn Array,
options: &CastOptions,
) -> Result<VariantArray, ArrowError> {
+ // Create row builder for the input array type
Review Comment:
Done in e1f4642, using your wording.
##########
parquet-variant-compute/src/cast_to_variant.rs:
##########
@@ -1143,6 +1143,58 @@ mod tests {
}
}
+ #[test]
+ fn test_cast_to_variant_duration_or_interval_errors_empty_or_all_null() {
Review Comment:
Done in e1f4642. `test_cast_to_variant_duration_or_interval_errors` now
builds the empty and all-null cases from each array's `data_type()`: as the
type itself, as a list element, as a struct field, and as a sparse union child.
So the seven types are listed once. The `is_err` assertion now names the
generated type and the row count. The supported-type controls (`Int64`,
`List<Int64>`, and a union of `Int32` and `Utf8`) sit at the end of the same
test. The test still fails without the fix (on `List(Duration(s)) with 0
rows`), and with only the reorder (on the empty union case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]