Phoenix500526 opened a new pull request, #12254:
URL: https://github.com/apache/arrow-rs/pull/12254

   
   
   > [!IMPORTANT]
   >
   > Before opening this PR, [enable CI in your 
fork](https://github.com/apache/arrow-rs/blob/main/CONTRIBUTING.md#pull-requests-from-forks).
   >
   > **Delete this notice after enabling CI.**
   
   # Which issue does this PR close?
   
   <!--
   It is not necessary to raise an issue, but it is encouraged if it is a 
non-trivial
   enhancement/bug.
   
   If this PR relates to an existing issue, but does not fully resolve it, 
please change
   the wording below from "Closes #NNN" to "Relates to #NNN" or "Part of #NNN" 
to avoid
   false closing an issue.
   -->
   
   - Closes #8775
   
   # Rationale for this change
   
   <!--
   Why are you proposing this change? If this is already explained clearly in 
the
   issue then this section is not needed. Explaining clearly why changes are 
proposed
   helps reviewers understand your changes and offer better suggestions for 
fixes.
   
   Please try to explain the problem you are trying to solve in terms of the 
user-visible
   behavior, rather than the implementation.
   -->
   
   List fields use a different textual representation from fields in Struct, 
Map, and Union. This makes nested type descriptions inconsistent.
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is
   sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Reuse `format_field` for List, LargeList, ListView, LargeListView, and 
FixedSizeList. Their parser accepts the new field syntax alongside the existing 
syntax, including the legacy FixedSizeList comma form.
   
   # Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are 
they
   covered by existing tests, if so identify these tests)?
   
   If this PR claims a performance improvement, please include evidence such as
   benchmark results.
   
   DO NOT simply paste a list of commands ran to verify the code; this is what 
our
   CI is for and it pollutes the PR. ONLY explain if testing was included with 
this
   PR, or why it wasn't.
   -->
   
   Yes. The arrow-schema tests pass. Tests cover the new display format, 
parsing of existing strings, mixed old/new nested syntax, and rejection of 
malformed input.
   
   # Are there any significant user-facing changes?
   
   <!--
   Significant user-facing changes include:
   - Breaking public API change
   - Significant change to existing functionality (e.g. function returns 
something different)
   
   These need to be explicitly called out to ensure we have proper 
documentation if
   required and to ensure we follow proper semantic versioning.
   
   DO NOT restate the changes of this PR; if a bug was fixed and already 
explained
   above, we don't need this to be restated as a user-facing change.
   -->
   
   Yes. List types now display field names explicitly. For example, List(Int32) 
becomes List("item": Int32). Existing strings remain accepted by the parser. 
Applications that compare display strings will need to update their 
expectations.
   
   # AI usage disclosure
   
   <!--
   If you used AI tools, briefly describe what they helped generate.
   See 
https://github.com/apache/arrow-rs/blob/main/CONTRIBUTING.md#ai-generated-submissions.
   Delete this section if you did not use AI tools.
   -->
   Codex assisted with the implementation, tests, and I thoroughly review all 
the change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to