Phoenix500526 opened a new pull request, #12257: URL: https://github.com/apache/arrow-rs/pull/12257
> [!IMPORTANT] > > Before opening this PR, [enable CI in your fork](https://github.com/apache/arrow-rs/blob/main/CONTRIBUTING.md#pull-requests-from-forks). > > **Delete this notice after enabling CI.** # Which issue does this PR close? <!-- It is not necessary to raise an issue, but it is encouraged if it is a non-trivial enhancement/bug. If this PR relates to an existing issue, but does not fully resolve it, please change the wording below from "Closes #NNN" to "Relates to #NNN" or "Part of #NNN" to avoid false closing an issue. --> - Refs #6487 # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. Please try to explain the problem you are trying to solve in terms of the user-visible behavior, rather than the implementation. --> The Flight SQL CLI currently fetches every result from the server that handled the query, ignoring the locations returned in FlightEndpoint. Queries fail when that server directs the client to another server for result retrieval. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> - Follow grpc, grpc+tcp, and grpc+tls endpoint locations. Prefer explicit connection reuse; otherwise select the first supported, valid location that satisfies the TLS requirement. - Reuse the authenticated token and client connection options when connecting to an advertised server, without another handshake. Advertised servers are assumed to share the original authentication domain. - Enable TLS automatically for grpc+tls locations. The change is limited to the CLI. HTTP downloads, Unix sockets, and automatic retries are outside its scope. # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests, if so identify these tests)? If this PR claims a performance improvement, please include evidence such as benchmark results. DO NOT simply paste a list of commands ran to verify the code; this is what our CI is for and it pollutes the PR. ONLY explain if testing was included with this PR, or why it wasn't. --> CLI integration tests cover cross-server retrieval of multiple result partitions, explicit and handshake-issued tokens, absence of additional handshakes, candidate location selection, explicit connection reuse, and errors when no supported location exists. A separate CLI test verifies that grpc+tls initiates a TLS handshake without --tls. Existing certificate and TLS integration tests are unchanged. Mutation testing confirmed that the tests detect regressions in routing, token propagation, handshake behavior, location selection, connection reuse, and automatic TLS activation. # Are there any significant user-facing changes? <!-- Significant user-facing changes include: - Breaking public API change - Significant change to existing functionality (e.g. function returns something different) These need to be explicitly called out to ensure we have proper documentation if required and to ensure we follow proper semantic versioning. DO NOT restate the changes of this PR; if a bug was fixed and already explained above, we don't need this to be restated as a user-facing change. --> No public library API changes or new CLI options. # AI usage disclosure <!-- If you used AI tools, briefly describe what they helped generate. See https://github.com/apache/arrow-rs/blob/main/CONTRIBUTING.md#ai-generated-submissions. Delete this section if you did not use AI tools. --> AI tools assisted with implementation, test development, code review, mutation testing, and drafting this PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
