dmitry-chirkov-dremio commented on PR #55607:
URL: https://github.com/apache/arrow/pull/55607#issuecomment-6881552947

   CI results for the new tests.
   
   Tests-only commit, before the fix:
   
   | Job | LLVM | `TestLLVMTypes SignedIntegerConstants` | `TestIfExpr 
TestNegativeConstants` |
   |---|---|---|---|
   | ARM64 macOS 26 C++ | 23.1.4 | aborts in `APInt` (`Value is not an N-bit 
unsigned value`) | aborts, same assertion |
   | ARM64 Ubuntu 22.04 C++ | 18.1.8 | fails, then aborts | passes, the LLVM 18 
`APInt` constructor always clears the unused bits |
   | AMD64 macOS 15-intel C++ | 18.1.8 | fails, then aborts | passes, same 
reason |
   | AMD64 Ubuntu 24.04 C++ ASAN UBSAN | 18.1.3 | fails, then aborts | passes, 
same reason |
   
   - **macOS ARM64:** this is the GH-45999 assertion. The abort kills the test 
binary, so `TestNestedNegativeFallback` never ran there.
   - **LLVM 18:** `SignedIntegerConstants` fails on 
`i128_constant(-1).isAllOnes()` (`llvm_types_test.cc:71`), then 
`getSExtValue()` on the `i128` value asserts.
   - **Not as predicted:** the `IF` tests pass on LLVM 18. In LLVM 18.1.8 the 
`APInt` constructor always calls `clearUnusedBits()` for a single-word value. 
In LLVM 21.1.7 it does that only when the signed flag is set. So for 16, 32 and 
64 bits the bug shows only on newer LLVM: wrong results on 21 locally, abort on 
23 in CI. The `i128` constant is wrong on every version, so on LLVM 18 only 
`SignedIntegerConstants` catches the bug.
   
   With the fix commit, `gandiva-internals-test`, `gandiva-precompiled-test` 
and `gandiva-projector-test` pass on all four platforms.
   
   A few known failures seen previously also appeared. They are not related to 
this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to