AynSiddiqui commented on issue #1538: URL: https://github.com/apache/arrow-go/issues/1538#issuecomment-6883856228
Reproduced on main (fc5d5ce): with 65,537 one-value pages, `serializedPageWriter.pageOrdinal` (int16) wraps to 0, so `data_page_offset` becomes 3211268 instead of 4 and ReadTable fails with EOF. Plan: widen it to int32 with a unit test, and return an error when an encrypted chunk's page ordinal would exceed 32,767, the largest value the 2-byte AAD field holds (as Arrow C++ #15182 and parquet-java do), instead of wrapping it silently. Should I also widen `serializedPageReader.pageOrd` here, or leave the reader for a follow-up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
