dmitry-chirkov-dremio commented on PR #55608: URL: https://github.com/apache/arrow/pull/55608#issuecomment-6884436481
CI results for the new tests. Tests-only commit, before the fix: 10 of the 11 new tests fail, as predicted. `gandiva-internals-test` and `gandiva-projector-test` fail on all four platforms (ARM64 Ubuntu 22.04 LLVM 18.1.8, AMD64 Ubuntu 24.04 ASAN UBSAN LLVM 18.1.3, AMD64 macOS 15-intel LLVM 18.1.8, ARM64 macOS 26 LLVM 23.1.4). The same tests fail everywhere: - `TestExpressionCacheKey`: `IfLiteralBoundaries`, `OutputTypeAndAlias`, `InSetsAreDelimitedAndOrdered`, `BooleanStructure`, `LikeThreadUniquifier`, `TypeParametersAreKept`, `RepeatedNamesAndTypesStayDistinct` - `TestBooleanExpr.CacheKeepsAndOrStructure` - `TestIfExpr.CacheKeepsStringLiteralBoundaries` - `ValidationTestProjector.TestCachedOutputTypeValidation` None of them crash. They fail on an expectation, for example two different expressions with the same key, or wrong output after a cache hit. `TestExpressionCacheKey.FloatingPointBitsAndNulls` passes on main, because float and double literals already print raw bits. It guards the new key. With the fix commit, both test binaries pass on all four platforms. I added four more regression tests after that, checked locally on the old key: - `ValidationTestProjector.TestCachedFieldNullabilityValidation` fails on the old key. A field node with the wrong nullability is rejected on the first `Make` and accepted after a valid one was cached. - `TestExpressionCacheKey.NullChildNodes` crashes the old key with SIGSEGV. - `TestProjector.TestProjectCacheSchemasDifferingInNullability` and `TestFilter.TestCacheSchemasDifferingInNullability` pass on both keys. Schemas that differ only in nullability already get separate cache entries. They record that behavior. On the current head (`cb1781d33e`), the Gandiva tests pass on all four platforms. A few known failures seen previously also appeared. They are not related to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
