AnuragRaut08 opened a new pull request, #55620:
URL: https://github.com/apache/arrow/pull/55620

   ### Rationale for this change
   
   Currently, Arrow creates the `arrow_bundled_dependencies` and 
`arrow_gcs_bundled_dependencies` imported targets manually in the installed 
CMake package configuration files.
   
   This makes the bundled dependency archives harder to manage through CMake's 
standard install and export mechanisms.
   
   This change exports these archives as regular CMake targets using 
`install(TARGETS)`.
   
   ### What changes are included in this PR?
   
   - Replace the manually created imported bundled dependency targets with 
regular static library targets.
   - Update `arrow_create_merged_static_lib()` to create a real static library 
target and merge dependency archives using a post-build command.
   - Export and install Arrow and Arrow GCS bundled dependency targets through 
their respective CMake exports.
   - Propagate external link requirements from the bundled dependencies through 
their installed target interfaces.
   - Move platform-specific AWS CRT link requirements for Apple and Windows 
into the `aws-c-common` target.
   - Remove the manual bundled dependency target creation from 
`ArrowConfig.cmake.in` and `ArrowGcsConfig.cmake.in`.
   
   ### Are these changes tested?
   
   Tested locally on Linux:
   
   - Built and installed Arrow with bundled mimalloc, uriparser, and simdjson.
   - Verified that the merged `libarrow_bundled_dependencies.a` archive 
contains 48 members.
   - Built and ran a downstream Arrow-only CMake consumer that performs a 
memory allocation using the mimalloc backend.
   - Built and installed Arrow with GCS enabled and bundled google-cloud-cpp.
   - Built and ran a downstream GCS CMake consumer successfully.
   - Verified that the installed GCS targets do not contain nlohmann_json 
references.
   - Verified that the installed GCS package discovers CURL and OpenSSL as 
system dependencies.
   - Ran the `cmake-format` pre-commit hook successfully.
   - Ran `git diff --check`.
   
   Not tested:
   - macOS and Windows builds.
   - Bundled Abseil configuration.
   - S3 and Flight bundled dependency configurations.
   - R packaging build. The R configure scripts and bundled archive references 
were reviewed, but the packaging build was not run.
   
   ### Are there any user-facing changes?
   
   No. These changes affect the CMake build, installation, and package export 
behavior. There are no intended changes to Arrow's public APIs.
   
   **PR code and description written by:**
   
   - [x] Human
   - [ ] AI
   
   **Reviewed before submission by:**
   
   - [x] Human
   - [ ] AI
   - [ ] Not reviewed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to