mhatipog commented on PR #12266:
URL: https://github.com/apache/arrow-rs/pull/12266#issuecomment-6901877877

   Tested this against real fastparquet files, as offered in #12265.
   
   Files: written by fastparquet 2026.9.0 (pandas, `fastparquet.write`), three 
0-row files (`Int32`; `int64`+`object`+`float64`+`datetime64[ns]`; `string`) 
and one 3-row `Int32` file as a control. Each file is opened with 
`SerializedFileReader::new` and read to the end with 
`ParquetRecordBatchReaderBuilder` (sync).
   
   | File | base 112f01f19 | this PR bcba0d92 |
   | --- | --- | --- |
   | empty Int32 | `Expected list element type of Struct but got Byte` (both 
readers) | ok, 0 row groups, 0 rows |
   | empty, 4 columns | same error (both readers) | ok, 0 row groups, 4 
columns, 0 rows |
   | empty string | same error (both readers) | ok, 0 row groups, 0 rows |
   | 3 rows Int32 (control) | ok, 1 row group, 3 rows | ok, 1 row group, 3 rows 
|
   
   So the fix covers the files fastparquet actually writes, not only the 
patched-footer case in the tests, and non-empty files read the same as before. 
Thanks for picking this up.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to