Phoenix500526 opened a new pull request, #12279:
URL: https://github.com/apache/arrow-rs/pull/12279

   # Which issue does this PR close?
   
   Closes #1706
   
   # Rationale for this change
   
   Downstream Flight servers need the protocol descriptors to expose their APIs 
through gRPC reflection without regenerating the protobuf definitions 
themselves.
   
   # What changes are included in this PR?
   
   Generate and vendor the Flight descriptor set, including its Timestamp 
dependency, and expose it as `arrow_flight::FILE_DESCRIPTOR_SET`. Enable 
reflection v1 in the Flight SQL server example, with a private 
service-registration helper shared by the example and its tests. 
`tonic-reflection` is a development dependency.
   
   # Are these changes tested?
   
   The new `test_reflection` runs over Unix sockets, HTTP, and mutual TLS. It 
checks service discovery, reflected message definitions and imported 
descriptors, and a successful `ListActions` call. Removing reflection 
registration makes the test fail. The existing Flight tests and example tests 
also pass, and reflection was verified manually with `grpcurl` without local 
proto files.
   
   The descriptor retains source metadata. It matches the output of the local 
protoc 29.3 installation; the local 3.20.3 and 3.21.1 installations produce 
different Timestamp source metadata, while the protocol definitions remain 
identical. The existing vendored-code CI check will verify regeneration in the 
CI environment.
   
   # Are there any significant user-facing changes?
   
   No breaking API changes. Enabling reflection remains opt-in for downstream 
servers.
   
   # AI usage disclosure
   
   Codex assisted with the implementation, regression test, validation, and 
code review.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to