Abdallah-Afifi commented on PR #11539: URL: https://github.com/apache/arrow-rs/pull/11539#issuecomment-6914492743
@Rich-T-kid since you've been through this part of the encoder on #11984 — would you be willing to take a look at this one as well? It's the sibling subtask from the same ALP cluster (#10645, configurable vector size), and it has been sitting without review for a while. It is green and conflict-free after the #11481 rebase. The one open question is a judgement call rather than anything broken: making the vector size a runtime value costs roughly 5–7% on f32 streaming encode, with the method and numbers in the description. The alternative is dispatching to const-generic instantiations across all 13 permitted sizes, which I'm happy to write instead. I also tried keeping a const fast path just for the default 1024 and measured it as no better than plain `chunks_exact`, so that middle option looks closed. @sdf-jkl asked for the PR so he could see the implementation, so the decision is really his — but a second opinion on whether that f32 cost is acceptable would help move it along. No obligation if you're busy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
