mbutrovich commented on PR #12018:
URL: https://github.com/apache/arrow-rs/pull/12018#issuecomment-6921057859

   > Do you want the bench groups in their own PR first, so the bot has a 
baseline on main? I can open one if so.
   
   A second PR isn't needed. The bot can compare against any commit with a 
`baseline: ref:` override 
([README](https://github.com/adriangb/datafusion-benchmarking/blob/60a1e0e024fecd0e49a50b5b9d1ce574c5be59e3/README.md?plain=1#L94-L113)),
 including a commit on a fork PR. What the branch lacks is a commit that has 
both bench groups and the old loop. `Int32ListList` came before the original 
rewrite, and `Int32LongList` came after the one-line change.
   
   Could you rebase onto `main` as two commits, with both bench groups first 
and the one-line change second? Then I'll run the bot with the bench commit as 
the baseline, once on its default Neoverse-V2 nodes and once with `arch: 
amd64`. When those results are in, please replace the M5 table in the 
description with them, since downstream users deploy on those CPUs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to